Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to make the sass file BS4 compatible. #583

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

precisioninfinity
Copy link

The idea here is to make changes so that the css will be compatible with BS4 SASS source to match BS4 branding colors, yet still work independently if BS4 is not used. This change also improves breakpoints to align with bootstrap 4 breakpoints. All required mixins and variables are copied into this file so it can be used independent of BS4. However, if a user has BS4 source, they can uncomment the import statements and the BS4 source will automatically take precedence over the local variables and mixins.

These upgrades might change the look of really small screens slightly from how it was before but I did some quick testing and it looked ok. There are some things that were not tested such as the 'close button' and the other options like it should be double checked before this is used in the main branch.

No updates were made to the LESS file, so that file may interfere depending on how the build is currently setup.

This change updates the SASS file so that it can be used better with BS4 by aligning to BS4 breakpoints and using the BS4 variables for the colors (keeping the colors consistent and making it easier to change the branding to match the BS4 branding colors).  This change will still work if the BS4 source is not included by having all the required variables and mixins right in this source file, however, if a dev has the BS4 source, uncomment the import statements and the BS4 source will override the values defined in this file.

Changes to this file also were done to use a 'mobile-first' approach of BS4.  Therefore some of the breakpoints might not look exactly as they did before this change, but I did some quick testing at smaller screen sizes and it looked ok.  There are also some things that were not tested such as the 'close button' and other options that should be double checked before this is used in the main branch.
@precisioninfinity precisioninfinity changed the title Improvements to make sass BS4 compatible. Improvements to make the sass file BS4 compatible. Jul 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant